-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: modify n simultaneous downloads; update buildutils #154
Open
bluegenes
wants to merge
21
commits into
main
Choose a base branch
from
mod-permits
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+330
−448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluegenes
force-pushed
the
mod-permits
branch
from
December 10, 2024 19:45
1f6e698
to
71d699f
Compare
bluegenes
force-pushed
the
mod-permits
branch
from
December 17, 2024 18:53
ef5f569
to
075d798
Compare
bluegenes
changed the title
WIP: modify n simultaneous downloads; update buildutils from bw
MRG: modify n simultaneous downloads; update buildutils
Dec 24, 2024
ok @ctb this one is ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the changes to
BuildUtils
(MultiSelection
details, minor changes toBuildCollection
filtering + writing) that arose from integration into branchwater. It also makes the number of simultaneous downloads tunable, since I was having trouble when using the 3 default permits with large eukaryotic genomes.It also handles changes associated with zipfile handling from sourmash-bio/sourmash#3431 arising from updating sourmash core to 0.18.0
ref #134